search

sroberts / hubot-vtr-scripts

Scripts for making Hubot a CND Sidekick
MIT License
59 stars 15 forks source link

Ssltester #32

Closed mattjay closed 10 years ago

mattjay commented 10 years ago

Very basic script that generates a link to get some info about an SSL cert. Need to improve further to actually make a request and parse out some useful info but the SSL Tester I'm using isn't ideal for this. Screen scraping :-1:

mattjay commented 10 years ago

@sroberts @technoskald won't merge until you check it out. Fine with leaving this PR open until the script gets a bit further but figured I'd send it over to see if we want to merge it in as is and improve it later.

sroberts commented 10 years ago

So I don't actually hate keeping it basic. I've made the mistake myself of making the VTR scripts a bit too verbose. Hubot is a bit more personal than that. Using something like Rhodey with BeautifulSoup might be ideal actually.

mattjay commented 10 years ago

@sroberts Hmmm never used BeautifulSoup before. Any of you python folk want to take a stab or at least show me some examples where hubot uses it? Either way I vote we merge this as is for now to kick the tires and can improve it later.

krmaxwell commented 10 years ago

Concur. On Dec 12, 2013 11:29 AM, "Matt Johansen" notifications@github.com wrote:

@sroberts https://github.com/sroberts Hmmm never used BeautifulSoup before. Any of you python folk want to take a stab or at least show me some examples where hubot uses it? Either way I vote we merge this as is for now to kick the tires and can improve it later.

— Reply to this email directly or view it on GitHubhttps://github.com/sroberts/hubot-vtr-scripts/pull/32#issuecomment-30443214 .

mattjay commented 10 years ago

Cool. sounds like this is a go to merge then.