sroberts / hubot-vtr-scripts

Scripts for making Hubot a CND Sidekick
MIT License
59 stars 15 forks source link

NPM package setup #5

Closed sroberts closed 10 years ago

sroberts commented 10 years ago

I'm told an NPM package is the best way to put this together for users. This is my first crack at setting that up.

@technicalpickles any thoughts?

sroberts commented 10 years ago

Alright, just for my own tracking: hit npm user, just need to send npm publish to publish that script. Doesn't take into account hubot-vtr-downloader.sh.

technicalpickles commented 10 years ago

Looks like test/hello-world_test.coffee was copied from https://github.com/hubot-scripts/hubot-example/blob/master/test/hello-world_test.coffee . I don't expect this would work (but script/test should confirm), so may as well remove it.

sroberts commented 10 years ago

@technicalpickles Alright, I think I'm more up to date. Hows this look?

I'm also wondering what the best way to DL those community scripts is. Do you have a better idea than that shell script?

krmaxwell commented 10 years ago

I'm not the Git expert you two are, but with the new structure of the Hubot community script repo, can't you just add the ones you like as subtrees or summat?

technicalpickles commented 10 years ago

I'm also wondering what the best way to DL those community scripts is. Do you have a better idea than that shell script?

You could include hubot-scripts as a git submodule, like maybe vendor/hubot-scripts. Then, in index.coffee require the things that you want.

sroberts commented 10 years ago

Successfully pushed to NPM. Need to test a new deploy from this method.

sroberts commented 10 years ago

Added to NMP, had to bump the config and version. Still need to: