Ensure the code submitter sees the correct domain

srobo / ansible

Ansible configuration for Student Robotics' pet machines

MIT License

0 stars 4 forks source link

Ensure the code submitter sees the correct domain #37

Closed RealOrangeOne closed 1 year ago

RealOrangeOne commented 1 year ago

Summary

The code submitter always uses absolute URLs (including domain). It only sees the competitorsvcs hostname, so uses this for the URLs. Now we allow the competitorsvcs VM to accept traffic with a studentrobotics.org host

Code review

Testing

[x] already running on production
[x] manually validated the new behaviour

Links

RealOrangeOne commented 1 year ago

Raised upstream: https://github.com/PeterJCLaw/code-submitter/issues/31

PeterJCLaw commented 1 year ago

Comparing to the old setup (i.e: on patience via https://github.com/srobo/server-puppet/blob/master/modules/www/templates/nginx.conf.erb) it looks like the thing which is extra here is that the server being proxied didn't previously care about its hostname -- it didn't redirect users if the hostname was wrong. I think that that behaviour is probably more correct for a server which we know is going to be behind a proxy.