Territories which are disconnected don't count towards breakage

WillB97 commented 3 years ago

Fix the bug

PeterJCLaw commented 3 years ago

Would be great to have some tests for this.

WillB97 commented 3 years ago

While having a test case may have prevented this issue in the first place, since we have now fixed this and the lock-out system isn't going to have any changes before it's removal at the end of this year the addition of a test case at this point seems of little benefit.

PeterJCLaw commented 3 years ago

While having a test case may have prevented this issue in the first place, since we have now fixed this and the lock-out system isn't going to have any changes before it's removal at the end of this year the addition of a test case at this point seems of little benefit.

I appreciate this that it feels like this may not change, however I'm not sure this is the right approach:

experience shows that things change much more than you'd think and often in ways that you don't predict. The number of times I've thought "nah, this won't change, I don't need to write tests" is nonzero. The number of times I've been right about that assumption is zero.
as well as helping developers have confidence in correct behaviour, tests help readers understand the expected behaviour of the code and how it should be used

WillB97 commented 3 years ago

I've added tests for cut-off territories and locking territories through self-claiming

srobo / competition-simulator

Territories which are disconnected don't count towards breakage #320