Improve robot to better suit SR2023

srobo / competition-simulator

A simulator for Student Robotics Virtual Competitions

https://studentrobotics.org/docs/simulator/

MIT License

8 stars 2 forks source link

Closed Adimote closed 1 year ago

Adimote commented 1 year ago

This change does the following:

Raise the camera, pan it down, and increase the FOV so it can see over tokens better
Widen the grabber and raise it so it can reach over the arms of the plinth

Here's a screenshot, including a FOV of the camera.

Top-down view with a golden token so you can see the clearance:

Side-on view with a bronze token and a camera perspective:

PeterJCLaw commented 1 year ago

@Adimote this looks fine in general, however have you seen the CI failures?

Adimote commented 1 year ago

linting errors now look unrelated

PeterJCLaw commented 1 year ago

Yeah, I think that linting error is actually a pyflakes bug!

PeterJCLaw commented 1 year ago

Scratch that, not a bug, feature was explicitly dropped in the latest major version.

PeterJCLaw commented 1 year ago

https://github.com/srobo/competition-simulator/pull/358 should fix the lint issue; we can either merge that here or just ignore it.