search

srobo / competition-simulator

A simulator for Student Robotics Virtual Competitions
https://studentrobotics.org/docs/simulator/
MIT License
8 stars 2 forks source link

Fix lighting intensity #365

Closed PeterJCLaw closed 1 year ago

PeterJCLaw commented 1 year ago

I'm guessing that this changed somehow when we rebuilt the arena this year.

The main change here is that the in-match intensity is decreased from 3.5 to 2.5. The other changes are small refactors ahead of pulling that value to a top level constant.

Fixes https://github.com/srobo/competition-simulator/issues/364.

Before before

After

https://user-images.githubusercontent.com/336212/219198413-4501567e-19a4-4751-997f-cc38cdeb51e0.mp4

WillB97 commented 1 year ago

Have you disabled "Ambient Occlusion" before making this change? When AO is enabled at any level it seems to add a significant amount of bloom which could have been your original issue.

PeterJCLaw commented 1 year ago

Have you disabled "Ambient Occlusion" before making this change? When AO is enabled at any level it seems to add a significant amount of bloom which could have been your original issue.

Yes, I was working through the "Running competition matches" docs when I found this. Would be good to confirm that it's not just my machine though.

PeterJCLaw commented 1 year ago

https://user-images.githubusercontent.com/336212/216830693-bc10d1d7-d06f-4bcb-9d1b-931d277c0ce7.mp4

WillB97 commented 1 year ago

It could do with being darker at the start.

PeterJCLaw commented 1 year ago

https://user-images.githubusercontent.com/336212/219164335-9e9ccd48-d2df-4ddb-8aa7-819ec26205c6.mp4

PeterJCLaw commented 1 year ago

https://user-images.githubusercontent.com/336212/219166753-5d96fd30-9d1a-466d-9fea-3e843f037fc2.mp4