search

srobo / competition-simulator

A simulator for Student Robotics Virtual Competitions
https://studentrobotics.org/docs/simulator/
MIT License
8 stars 2 forks source link

Revert vision changes #376

Closed PeterJCLaw closed 1 year ago

PeterJCLaw commented 1 year ago

The recent vision improvements are technically breaking, additionally they unfortunately still have the underlying bug where orientation data is messed up (due to orientation issues in Webots),

They do however fix an issue where markers sometimes can't be seen (which is actually a result of the orientation data being messed up). If we're going to do breakage it would be nice to do it all in one go, once we've fixed the orientation data.

This PR reverts the recent vision changes so we can put out a release with the other changes separately.

Note: I haven't tested this at all -- it's just a revert of the commits I'm aware touched vision stuff, plus a small fix for CI.

Adimote commented 1 year ago

I did a few checks of X/Y orientation on a marker in a few orientations, and cartesian distances, it seems like the measurements are the same as pre-vision changes (commit 64d5994) tag: sr2023.3