srobo / competition-simulator

A simulator for Student Robotics Virtual Competitions
https://studentrobotics.org/docs/simulator/
MIT License
8 stars 2 forks source link

Capture the end-of-match screenshot before fade-down #391

Open PeterJCLaw opened 1 year ago

PeterJCLaw commented 1 year ago

This changes when we capture the end-of-match screenshot to just before the fade-down rather than afterwards, in order to present a more consistent view of the world relative to the captured video.

It appears that the video itself only captures a frame or two into the red fade-down, meaning that there's up to 80ms between the end of the video and when the post-fade-up screenshot is captured. When comparing that screenshot to the end of the video there can therefore be considerable discrepancies, which are rather unexpected.

With this change we present a more consistent view of the world.

Contributes to #386.