search

srobo / competition-simulator

A simulator for Student Robotics Virtual Competitions
https://studentrobotics.org/docs/simulator/
MIT License
8 stars 2 forks source link

Improve windows support around run-comp-match #450

Closed PeterJCLaw closed 6 months ago

PeterJCLaw commented 6 months ago

I'm pretty confident we want the first change here (docs)~, less sure about the second. The latter definitely needs testing by someone on Windows. I can probably do that at some point, but I don't know if I have webots setup/etc. on my Windows machine so if someone who does is able to review that before I get back to this please do so!~

Have now tested this on Windows & fixed a small issue. In my testing I didn't have the right Python packages installed so the simulation only got as far as that check, however I think that's still far enough to prove that the rest of the system worked -- it was able to execute Python to run the match script, which found Webots via WEBOTS_EXECUTABLE which was subsequently able to launch Python to run the "user" code.

Testing was based on a manually taken copy of the batch script dropped into an existing copy I had of the sr2024.1 release.

PeterJCLaw commented 6 months ago

@prophile was that a "looks good" approval or were you also able to validate the script?

PeterJCLaw commented 6 months ago

@Adimote confirmed this works too :)