search

srobo / infrastructure

Obsolete. Provisions the base infrastructure in DigitalOcean
MIT License
0 stars 0 forks source link

Convert to standard terraform flow #11

Open RealOrangeOne opened 4 years ago

RealOrangeOne commented 4 years ago

This changes to use terraform workspaces rather than the previous rake_terraform setup.

This also switches to using a system installed version of terraform, but there's various way's of doing that, so no need to be opinionated.

I also removed the development setup, as it was a lot of extra complexity and abstraction for 0 gain.

The goal of this PR is not to make this repository reflect reality. But simply to make it maintainable so it can easily be done in future.

To Do:

(Moving to an actual remote state backend is OOS of this PR, but definitely on my list!)

PeterJCLaw commented 3 years ago

What's the reason for moving the files from src into the root? (Doing this makes review harder because we don't get file diffs, unless the file really are being fully rebuilt?)

PeterJCLaw commented 3 years ago

What's the reason for moving the files from src into the root? (Doing this makes review harder because we don't get file diffs, unless the file really are being fully rebuilt?)

Oh and it also means that the content (i.e: terraform) files are mixed in with the meta files (e.g: README). Unless there's a technical reason to do this I'd encourage that we push the content down a level.