search

srobo / infrastructure

Obsolete. Provisions the base infrastructure in DigitalOcean
MIT License
0 stars 0 forks source link

www. form of the domain presents security warning rather than redirecting #2

Closed PeterJCLaw closed 5 years ago

PeterJCLaw commented 5 years ago 
$ curl -i https://www.studentrobotics.org
curl: (51) SSL: certificate subject name (studentrobotics.org) does not match target host name 'www.studentrobotics.org'

Prior to the move to this incarnation of our infrastructure this used to work, but now fails.

This also means that a number of git repo clones, including those on patience no longer work as our HTTPS git clone urls all use the www. form of the url.

jimmythompson commented 5 years ago

This looks like it's because the certificate doesn't contain any subdomains including www.. I'll take a look, but feel free to give it a try.

PeterJCLaw commented 5 years ago

Yeah, I think we might need a cert for both. I'm not sure what happens if you present a www.foo.tld cert for foo.tld, but I think I'd expect that to error similarly to how this is (otherwise it would allow subdomains to impersonate the root).

jimmythompson commented 5 years ago

It looks like it's working? 🤷‍♀

PeterJCLaw commented 5 years ago

What did you change?

jimmythompson commented 5 years ago

I amended the certificate and added www.

On Tue, 23 Jul 2019 at 22:54, Peter Law notifications@github.com wrote:

What did you change?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/srobo/infrastructure/issues/2?email_source=notifications&email_token=AAE7UKFVUQFBXYLRVQJBZ23QA54YBA5CNFSM4IGIW7H2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2URP5Q#issuecomment-514398198, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE7UKDNYST4Q6BIOIHNLTDQA54YBANCNFSM4IGIW7HQ .