search

srobo / livestream-overlay

Overlay of the livestream using the sr-comp system
MIT License
0 stars 1 forks source link

Make sass dependency work on modern OSes #11

Closed PeterJCLaw closed 3 years ago

PeterJCLaw commented 3 years ago

Specifically on Ubuntu 20.04 there isn't Python 2 any more. Previously it seemed that the version of node-sass which was installed needed Python 2 as part of the build for node-gyp. This moves it to being a dev-dependency for clarity and then updates it to v5, which seems to avoid that issue.

trickeydan commented 3 years ago

node-sass is considered deprecated in favour of the Dart rewrite of sass, available on NPM under sass.

This feels like it is probably out of scope for this PR and deserves it's own issue? Breaking changes etc etc

PeterJCLaw commented 3 years ago

@RealOrangeOne thanks for the info, I wasn't aware of the sass changes. Do you feel strongly that we should hold up this PR on that basis? Currently I would push for getting this in because it does improve things, even if not perfectly.

RealOrangeOne commented 3 years ago

I feel it should be done, but definitely not strongly enough to block this PR. Let's get this in, as currently I can't even build the application on my machine, and we can deal with deprecations at a later date!