search

srobo / robot-image-legacy

Build scripts for 2022 System Image
1 stars 0 forks source link

Create a pull request template #30

Open raccube opened 3 years ago

raccube commented 3 years ago

We need a pull request template which prompts the user to test their change and asks which platforms the change was tested on.

trickeydan commented 3 years ago 
## Platforms Affected

- [ ] ODROID U3
- [ ] Raspberry Pi 3/3B+
- [ ] Raspberry Pi 4

## Checklist

- [ ] I have updated the relevant documentation
- [ ] I have tested builds of my changes on all affected platforms
- [ ] I would like multiple reviewers to approve my code before merging

## Why do you want to make these changes?

## Which parts of the build process do your changes affect?

## Do your changes affect student or volunteer experience? How so?

## Are your changes related to any existing issues or PRs? How so?
raccube commented 3 years ago

Shouldn't the first section be called Tested Platforms instead?

raccube commented 3 years ago

Although whoever is reviewing should test it themselves as well