Closed trickeydan closed 4 years ago
Force pushed to rebase on master
fyi, I've now made that herdsman PR: srobo/brain-herdsman#1
@sersorrel I need to get a functioning robot system first
lgtm
(might be nice to use a TypedDict for the loaded json
data
rather than Any, but honestly whatever)
Is there a backport of this to 3.6? I thought TypedDict was only available in 3.8+?
looks like typing-extensions has a backport, but I'm not convinced it's worth the extra dependency
looks like typing-extensions has a backport, but I'm not convinced it's worth the extra dependency
Pretty certain we already depend on that for Protocol
in j5
Not sure if it's in scope here.
This should make the new API work with herdsman in it's current state.
The arguments on the CLI should also be compatible.
I have not be able to run herdsman myself. Perhaps @sersorrel could have a go.
I have been testing it as follows:
mkfifo fifo
echo "{\"mode\": \"dev\", \"zone\": 0, \"arena\": 0}" > fifo
Fixes #5