srobo / srcomp-mixtape

A service which plays tracks throughout a competition.
0 stars 2 forks source link

Support OBS video playback #8

Closed PeterJCLaw closed 3 years ago

PeterJCLaw commented 3 years ago

This does some further refactoring to simplify things and then introduces support for telling OBS to play videos via obs-websocket-py.

This itself isn't tested, though I have previously tested OBS websocket usage like this in https://github.com/PeterJCLaw/obs-match-scheduler/blob/main/via-obs-websocket-py.

Fixes https://github.com/srobo/tasks/issues/655.

PeterJCLaw commented 3 years ago

I'm concerned that the current setup overly restricts us to using a singular machine running both mixtape and OBS while the use of websockets enables the option of these being separate.

I'm not sure why this would be a problem, nor why you'd want to run mixtape on another machine. Perhaps I should remove the hostname configuration option to clarify that that's not an expected use-case? If we were to run mixtape on another machine that would likely introduce latency and security issues, both of which are better off avoided.

I really don't view the use of websockets here as a way to decouple OBS from mixtape, but rather only as a convenient interface.

WillB97 commented 3 years ago

Setup notes: For the source being controlled the option Close file when inactive needs to be set to allow the source to be changed when not active. The scene being transitioned to needs Transition Override > Fade selected so there is a fade