srobo / tools

Student Robotics development helper scripts
4 stars 3 forks source link

Update subprocess launching to be sane & secure #42

Open PeterJCLaw opened 3 years ago

PeterJCLaw commented 3 years ago

There's rather a lot of subprocess.Popen usage here, many of which use string formatting of one form or another to build the command they run. This may or not be insecure, we just don't know. Using the list based approach would be better. Likely other utils in subprocess can also now simplify them.