sromku / android-simple-facebook

[Deprecated] Simple Facebook SDK for Android
Other
879 stars 349 forks source link

SessionManager NPE #378

Open DmitryGlotov opened 8 years ago

DmitryGlotov commented 8 years ago

Hello, sometimes i have that exception: lib version 4.0.8

Caused by java.lang.NullPointerException com.sromku.simple.fb.SessionManager$LoginCallback.onCancel (SessionManager.java:66) com.facebook.login.LoginManager.finishLogin (LoginManager.java:506) com.facebook.login.LoginManager.onActivityResult (LoginManager.java:193) com.facebook.login.LoginManager$1.onActivityResult (LoginManager.java:136) com.facebook.internal.CallbackManagerImpl.onActivityResult (CallbackManagerImpl.java:82) com.sromku.simple.fb.SessionManager.onActivityResult (SessionManager.java:84) com.sromku.simple.fb.SimpleFacebook.onActivityResult (SimpleFacebook.java:1877)

pgreze commented 8 years ago

+1 and the problem should also happened during onError invocation. Only onSuccess is checking if loginListener != null before using it.