search

srophe / bethqatraye-data

Data repository for bethqatraye
0 stars 0 forks source link

HTTPS or HTTP? #60

Closed davidamichelson closed 4 years ago

davidamichelson commented 4 years ago

@wsalesky It seems we have some URIS as https: and some as http:

Ex: https://bqgazetteer.bethmardutho.org/place/2982

What did we decide? I think we decided on HTTPS? I will change the data to be uniform, but please let me know if HTTPS is fine.

Will that break any scripts?

wsalesky commented 4 years ago

@davidamichelson It should not cause any issues as long as the base-uri declared here: https://github.com/srophe/bethqatraye/blob/master/repo-config.xml#L30 matches.

davidamichelson commented 4 years ago

Hmm, there seems to be both https and http in there. Compare lines 22 and 30

https://github.com/srophe/bethqatraye/blob/50a6fcc4624adda190318620ae5af628fb831451/repo-config.xml#L22-L30

Should we use HTTPS for everything?

wsalesky commented 4 years ago

Looks like a bad merge there should only be one. I'm fine using https.

davidamichelson commented 4 years ago

Okay, HTTPS it is!

davidamichelson commented 4 years ago

Could you please change the code in the app to HTTPS and I will change the code in the data to HTTPS.

davidamichelson commented 4 years ago

I will let you know when I am done.

davidamichelson commented 4 years ago

Okay just pushed new data, but wait for an e-mail from me.

davidamichelson commented 4 years ago

Oops, will leave open until you change in the app

wsalesky commented 4 years ago

Done!