srophe / britishLibrary-data

GNU General Public License v3.0
0 stars 3 forks source link

How to handle use of TEI:choice in the data. #1511

Open davidamichelson opened 3 months ago

davidamichelson commented 3 months ago

see record 31 https://bl.syriac.uk/ms/31.tei

<title xml:lang="en">
<persName>
<choice>
<reg>Felix</reg>
,
<orig xml:lang="syr">ܦܝܠܟܣ</orig>
,
</choice>
of Rome
</persName>
</title>
davidamichelson commented 3 months ago

Replace choice with multiple persNames?

dlschwartz commented 3 months ago

Review all uses of tei:choice.

dlschwartz commented 3 months ago

I've found errors in the children that typically go into tei:choice as well. See for example the use of tei:sic in 70.xml.

dlschwartz commented 3 months ago

We need to do this for all persName/choice and placeName/choice. These are name variants usually in different languages. The orig element with an xml:lang ought be become a foreign element with the same xml:lang. The reg element should be removed and we should also include both/all (sometimes there are three) of these name variants in a single persName.

              <placeName>
                    <choice>
                      <reg>Hermopolis</reg>
                      <orig xml:lang="syr">ܗܪܡܦܘܠܝܣ</orig>
                    </choice>
              </placeName>

should become

              <placeName>
                    Hermopolis, <foreign xml:lang="syr">ܗܪܡܦܘܠܝܣ</foreign>
              </placeName>
dlschwartz commented 3 months ago

@davidamichelson @wlpotter See the above commit. It only allows sic/corr and abbr/expan as child of persName/choice and placeName/choice.

Here is the error message: As child of <persName>, <choice> can either be used to correct a mistake in the original print volume (using <sic> and <corr>) or to indicate an abbreviation and an expansion of that abbreviation (using <abbr> and <expan>). The <choice> element should not be used to mark up a name in different languages.

This is intended to throw an error when an encoder tries to use choice incorrectly for name variants given by Wright. Let me know if you don't want this rule.