search

srophe / britishLibrary-data

GNU General Public License v3.0
0 stars 3 forks source link

Fix Zotero URLs added from 4545590 group (old CBSC) rather than 4861694 group (correct CBSS) #1927

Closed wlpotter closed 1 month ago

wlpotter commented 1 month ago

There are 89 instances where previous encoders used the incorrect Zotero library (group id 4545590) instead of the correct CBSS Zotero library (group id 4861694). Please use the following steps to go through each and correct the Zotero links in the bibl/ref/@target attribute values.

Use the following branch: "issue1927-zotero-url-fixes" (https://github.com/srophe/britishLibrary-data/tree/issue1927-zotero-url-fixes)

Workflow for this:

  1. Search for "4545590" in all records
    • With any manuscript record open in oXygen
    • Use ctrl/cmd + shift + h for 'find-in-files'
    • Input "4545590" under "Text to find"; and select "Current file directory" under "Scope"
    • Select "Find All" at the bottom of the window
  2. For each of the results, update the Zotero URL to use the correct group library
    • Select and copy the full Zotero URL (double-clicking at the start of the attribute value will select the whole thing)
    • Open the Zotero URL in your browser
    • In a separate tab, open the correct CBSS Zotero library: https://www.zotero.org/groups/4861694/a_comprehensive_bibliography_on_syriac_studies/library
    • Search for the corresponding item in the 4861694 Zotero library
    • The metadata for the two records should be an exact match, aside from possible differences in the "Extra" field
    • Copy the Zotero URL of the correct item, ensuring both the group id (4861694) and item key string are included, e.g. "items/TB6F26NB"
    • Replace the attribute value in the XML file with the corrected Zotero URL
  3. After replacing all of the incorrect URLs in a file, save and commit those changes, you can reference this issue in the commit message by including #1927

Note: It should be the case that there will be an exact matching record between the two Zotero libraries, but if you come across a case where you cannot find a match, add a comment to this issue with the file number and the Zotero link that doesn't have a matching URL.

Once all of the changes have been made and committed for all of the files, i.e. when searching in all files for "4545590" returns 0 results, you can create a pull request from the "issue1927-zotero-url-fixes" branch into "development".

wlpotter commented 1 month ago

@haeleekim please take a look at the above and let me know if you have any questions on the workflow steps

wlpotter commented 1 month ago

Done, great work!