Closed davidamichelson closed 1 year ago
@davidamichelson here's a bit more context on authors in additions and finalRubrics that have English-language content
@xml:lang="en"
. I think we do want to include this in the search for translated titlesI also wonder if, for the URI search for works or authors we could do something similar to TSG's advanced search where you can narrow results by including a related person or work URI? The trick would be scoping this, I suppose, so the URI appears in the same msItem or additions context as the search string(s)? This might need further discussion
@davidamichelson @wlpotter For the Locus search, do you want a box for to and a box for from? So you can search a range?
@wsalesky Note to self, it may be easier to search by title/author fields that are constructed at index time.
@davidamichelson @wlpotter For the Locus search, do you want a box for to and a box for from? So you can search a range?
Sure! Let's have three boxes From, To, and Exact Folio
Note, for these, please only run the search for the numeric value of the search term (we will ignore "a" "b" "r" "v" in 21b or 34v)
On second thought, don't create a locus search for now!
@davidamichelson @wlpotter We forgot to discuss: Date: Let's discuss if perhaps the results could have a slider instead of a box for this. Script: Let's discuss if perhaps the results can be faceted by this instead of a box. Material: Let's discuss if perhaps the results can be faceted by this instead of a box.
If you give me the xpath I can go ahead and make facets.
Here are those xpaths:
/TEI/teiHeader/fileDesc/sourceDesc/msDesc/history/origin/origDate
. We will want to use the @notBefore
, @notAfter
, and @when
attributes.
//origDate
element with @notBefore-custom
, etc. attributes but we don't want to use these for the slider/TEI/teiHeader/fileDesc/sourceDesc/msDesc/physDesc/handDesc/handNote/@script
. We would want to use the labels from this comment./TEI/teiHeader/fileDesc/sourceDesc/msDesc/physDesc/objectDesc/supportDesc/@material
. We would want the labels from this comment under "Material Support"Let me know if you need anything further here
@wsalesky please proceed with Date, Script, and Material as facets and let's discuss if we also add them to search after that.
@davidamichelson @wlpotter Can I have some test cases to use for the 'limit by' part of the search? at least one test case per limit would be great!
@davidamichelson @wlpotter I have added everything but the 'Limit by' function. Please test and send any bugs. Thanks!
@davidamichelson @wlpotter for the 'Search in ' function, do you really want to limit all of the above options by these paths? Or just the keyword? For example, just search persons and places in /TEI/teiHeader/fileDesc/sourceDesc/msDesc/msPart/history ?
@davidamichelson @wlpotter Can I have some test cases to use for the 'limit by' part of the search? at least one test case per limit would be great!
We have split this off as its own issue and area waiting on this. No action needed.
Please add the following functions and boxes to advanced search. (Note, currently the search does not return anything).
[x] Keyword in Any Language: this box should search by string in all textnodes EXCEPT those that are contained in TEI:encodingDesc and TEI:profileDesc and children of those elements.
[x] Author: this box should search by string in all textnodes of all TEI:Author and TEI/:editor in msItem. (Could we allow this box to take both strings and Syriaca.org URIS and handle them differently--ie search for the string in textnode but search for the URI @ref?)
[x] #125
[x] #140
[x]
Locus: this box should search by numeric string only for exact match only in the //locus/@to and //locus/@from attributes[x] Place: this box should search by string in all textnodes of all TEI:placeName and origPlace. Please allow this box to take both strings and Syriaca.org URIS and handle them differently--ie search for the string in textnode but search for the URI @ref in placeName and origPlace. Please have a check box next to this search box which limits the search to origPlace nodes only. That check box would be labled "Limit search to place of origin.")
[x] Person: This box should search by string in all textnodes of all TEI:author, editor, and persName. Please allow this box to take both strings and Syriaca.org URIS and handle them differently--ie search for the string in textnode but search for the URI @ref
[x] #198
[x] Script: Let's discuss if perhaps the results can be faceted by this instead of a box.
[x] Material: Let's discuss if perhaps the results can be faceted by this instead of a box.
[x] #199
[x] #197 (Waiting on this for now).