srophe / caesarea-data

Data repository for Caesarea-Maritima.org
0 stars 2 forks source link

whitespace around placeName #128

Closed wlpotter closed 1 year ago

wlpotter commented 1 year ago

This issue is actually a data issue.

This will need a find-and-replace; or I'll need to dive back in to troubleshooting whitespace in basex

davidamichelson commented 1 year ago

@wsalesky Can you help us understand if we need to change the data or change the serialization into HTML?

Here is the code: Screen Shot 2022-09-23 at 3 20 56 PM

And here is the problem, it looks like the new line breaks before and after the TEI:quote elements are becoming spaces inside the quotation marks that we do note want: Screen Shot 2022-09-23 at 3 20 38 PM

Should we edit the data somehow?

Thanks

wsalesky commented 1 year ago

@davidamichelson @wlpotter which record is this? (Link to github is fine)

wlpotter commented 1 year ago

It's this record: https://github.com/srophe/caesarea-data/blob/master/data/testimonia/tei/214.xml

And these lines in particular.

Though I think this issue affects most, if not all, records

wlpotter commented 1 year ago

This is either an issue with BaseX's indentation setting (i.e., it's trying to 'pretty print' the output and introducing meaningful whitespace). Two options:

  1. Change BaseX output settings to stop adding whitespace in this way
  2. If that doesn't work, we can do a find and replace to remove this whitespace.
wlpotter commented 1 year ago

Note to self (and thanks @wsalesky for the suggestion) setting BaseX's options to not indent the xml output fixed this problem