srophe / caesarea-data

Data repository for Caesarea-Maritima.org
0 stars 2 forks source link

Abstract creation and update not finding tei:placeName elements in `/ab/*/placeName` #165

Closed wlpotter closed 1 year ago

wlpotter commented 1 year ago

Example is https://caesarea-maritima.org/testimonia/46

I noticed that the place name in the translation was not getting picked up by the abstract creator. And it turns out it's because it is nested inside a tei:foreign element first. Need to update cmproc:create-abstract-preamble-from-place-name-sequence in the post-processor to look for placeName descendants of ab, not just direct children.

Note that re-running the abstract should wait until #153 is sorted out so you don't propagate bad date formats.

wlpotter commented 1 year ago

This is fixed in post-processing and I'll run an update shortly. One other oddity is that in a few records we have either a tei:foreign or tei:lb element that snuck into the tei:placeName element:

foreign:

lb:

You can see the display oddities by searching the full browse page (https://caesarea-maritima.org/testimonia/browse.html?lang=&alpha-filter=ALL&start=1&perpage=332) for "Unknown, Honors for an Athlete, IAph2007 12.920".

I can update the script so it only grabs the text node if that would be preferred.

wlpotter commented 1 year ago

Note: this has been updated in data, but leaving open to ask about the tei:foreign and tei:lb elements found in tei:placeName elements.

wlpotter commented 1 year ago

Remove these from the abstract -- use the placeName/text()