search

srophe / caesarea

Application repository for Caesarea-Maritima.org
GNU General Public License v3.0
0 stars 0 forks source link

Browse by Letter, Facet, and Sort combine for confusion ;) #162

Closed davidamichelson closed 3 years ago

davidamichelson commented 3 years ago

This issue occurs in browse testimonia by author>letter for example in by author>J: https://caesarea-maritima.org/testimonia/browse.html?lang=&alpha-filter=J

It seems to work fine but note that Jerome is in the results but not listed in the facets:

Screen Shot 2021-01-04 at 4 10 57 PM

Next if on this same page one selects Sort>Title, then all the results change and the only visible results are by Flavius Josephus and neither Justinian nor Jerome are on the page or in the factes.

Screen Shot 2021-01-04 at 4 11 57 PM

Not sure if this related to these issues: https://github.com/srophe/caesarea/issues/132 and https://github.com/srophe/caesarea/issues/133

Lastly, please note that actually having Josephus show up here is fine (see issue https://github.com/srophe/caesarea/issues/161) as long as we have the other J results too. (I was not expecting Josephus to show up, however since the J is in his second name).

wsalesky commented 3 years ago

@davidamichelson Okay, there are a few things going on here.

  1. Not all the authors are appearing in the facets. This has now been fixed, there was an issue in how the facets were being generated.
  2. The sort by title is using the alphabetic filter on the TITLE, not the author. This creates a bit of a code conundrum for me. It will probably take me a few hours to sort it out.

Thanks for finding these, I will let you know when I unravel the second issue.

wsalesky commented 3 years ago

@davidamichelson I believe both of these are now fixed. Please close if you agree.

davidamichelson commented 3 years ago

Looks good! Found some other issues :)