srophe / caesarea

Application repository for Caesarea-Maritima.org
GNU General Public License v3.0
0 stars 0 forks source link

fixing spaces in texts on the homepage or launch-page #251

Closed josephrife closed 2 years ago

josephrife commented 3 years ago

Hi folks. Two related things here: 1) I noticed there are some misplaced commas/spaces around the site names in right-to-left scripts on the cover page: "... scholarship about the historic settlement of Caesarea Maritima (Καισάρεια, Caesarea Palestinae, قيسارية, קֵיסָרְיָה, ܩܣܪܝܐ, Keisarya or Qaysaria) on the Mediterranean coast ..." Or maybe I am wrong and I dont know how spaces and commas work in right-to-left scripts? 2) In terms of the order of place names in different languages, let's fix so that it goes: Greek, Latin, Hebrew, Syriac, Arabic, then the transliterated modern ones. Does that sound good? that would be historical. looked to me like Syriac preceeded Hebrew as it now stands. thx!

wlpotter commented 3 years ago

I believe number 1 is an app issue, but number 2 is a data issue. Splitting the data issue to https://github.com/srophe/caesarea-data/issues/91

wlpotter commented 3 years ago

@davidamichelson I think you can edit the text on the app? Looks like an HTML change

wlpotter commented 3 years ago

Ah, I misunderstood...This is all for the home page list of names...

davidamichelson commented 2 years ago

FIXED BY https://github.com/srophe/caesarea/pull/268 and https://github.com/srophe/caesarea/pull/269

wsalesky commented 2 years ago

@davidamichelson I believe this is fixed. Reopen if I missed anything

wlpotter commented 2 years ago

@wsalesky @davidamichelson the index and about pages look correct