Closed josephrife closed 2 years ago
@davidamichelson @wlpotter I can make this change if you like. However while looking at the taxonomy, I noticed there are many other time periods that follow the above format, should they all be changed? i.e. remove 'Period' and 'CE' from the labels?
@wsalesky @davidamichelson we can update the historical-era-taxonomy file with the changes, though we may want to get confirmation from the editors on how they would like the labels to appear.
Note to self: this will require a data issue as well to update the tei:taxonomy in records' teiHeader.
Data issue split off to https://github.com/srophe/caesarea-data/issues/92
Hi all -- my bad, there was a typo in my message--the years dates do need CE after them, so it should be "British Territorial Administration: 1917-1920 CE." So erase "Period" ('administration' already connotes a period of time, cf. "Kingdom" in earlier periods); and fix the date from 1970 to 1917. many tyhx
Joseph L. Rife Associate Professor Department of Classical and Mediterranean Studies Affiliated Faculty in Anthropology and Religion Director, The American Excavations at Kenchreai (Greece) Co-Director, The Caesarea City and Port Exploration Project (Israel)
From: Winona Salesky notifications@github.com Sent: Thursday, February 4, 2021 8:52 AM To: srophe/caesarea caesarea@noreply.github.com Cc: Rife, Joseph Lee joseph.rife@Vanderbilt.Edu; Author author@noreply.github.com Subject: Re: [srophe/caesarea] fixing date for British Mandate admin in chronology for testimonia (#256)
@davidamichelsonhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdavidamichelson&data=04%7C01%7Cjoseph.rife%40vanderbilt.edu%7C56d5b8e51e9e4184417008d8c91c6edb%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637480471263681341%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RNq%2BPGMAhgEFTbNJttZYcCXxfCUdvchohhBilSoDbuU%3D&reserved=0 @wlpotterhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwlpotter&data=04%7C01%7Cjoseph.rife%40vanderbilt.edu%7C56d5b8e51e9e4184417008d8c91c6edb%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637480471263681341%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=juzSJ5Gh6XnGrp3qtEcBErNJ5HOvXOAuprWT3u0Zfiw%3D&reserved=0 I can make this change if you like. However while looking at the taxonomy, I noticed there are many other time periods that follow the above format, should they all be changed? i.e. remove 'Period' and 'CE' from the labels?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsrophe%2Fcaesarea%2Fissues%2F256%23issuecomment-773367327&data=04%7C01%7Cjoseph.rife%40vanderbilt.edu%7C56d5b8e51e9e4184417008d8c91c6edb%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637480471263691334%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=HRM6%2B4jWufyYi4p2MK8QwCqnZNXRKmpcXKkIc6w5msI%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASMZS2AKYKNAWPED35IM4DTS5KYBFANCNFSM4WYKXWEQ&data=04%7C01%7Cjoseph.rife%40vanderbilt.edu%7C56d5b8e51e9e4184417008d8c91c6edb%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637480471263691334%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=735rPdFYSV3rpDHP03Vycpqjljys6dgWLxMKteyyYDU%3D&reserved=0.
All the periods/dates, once the British Territorial Administration is fixed, are fine .., except that I am not sure about "Iron IIC: 799-731 BCE" which seems off-- Will, was defined borrowed from somewhere e.g. the Anc Near East encyclopedia? many thx
Joseph L. Rife Associate Professor Department of Classical and Mediterranean Studies Affiliated Faculty in Anthropology and Religion Director, The American Excavations at Kenchreai (Greece) Co-Director, The Caesarea City and Port Exploration Project (Israel)
From: William L Potter notifications@github.com Sent: Thursday, February 4, 2021 12:39 PM To: srophe/caesarea caesarea@noreply.github.com Cc: Rife, Joseph Lee joseph.rife@Vanderbilt.Edu; Author author@noreply.github.com Subject: Re: [srophe/caesarea] fixing date for British Mandate admin in chronology for testimonia (#256)
@wsaleskyhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwsalesky&data=04%7C01%7Cjoseph.rife%40vanderbilt.edu%7C55c616210b8e4347067008d8c93c35bd%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637480607719456497%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=fg%2FlPoBdvuqxLv8D6UNgvDB7GMQf2OV9KUNFt0%2FllD0%3D&reserved=0 @davidamichelsonhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdavidamichelson&data=04%7C01%7Cjoseph.rife%40vanderbilt.edu%7C55c616210b8e4347067008d8c93c35bd%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637480607719456497%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Y9uOZh3qEmctmltY%2BQSe4w3zv1EQvkeKX8I%2BsJ9U4NE%3D&reserved=0 we can update the historical-era-taxonomy filehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsrophe%2Fcaesarea%2Fblob%2Fmaster%2Fdocumentation%2Fcaesarea-maritima-historical-era-taxonomy.xml&data=04%7C01%7Cjoseph.rife%40vanderbilt.edu%7C55c616210b8e4347067008d8c93c35bd%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637480607719466490%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=qaPD5j155%2Bg8iuREuSlUyWg%2Fhepa7bwlfHVIgwR%2Bl2o%3D&reserved=0 with the changes, though we may want to get confirmation from the editors on how they would like the labels to appear.
Note to self: this will require a data issue as well to update the tei:taxonomy in records' teiHeader.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsrophe%2Fcaesarea%2Fissues%2F256%23issuecomment-773521440&data=04%7C01%7Cjoseph.rife%40vanderbilt.edu%7C55c616210b8e4347067008d8c93c35bd%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637480607719466490%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=7isJ6%2BLdHyViJBR6jJ9oiqZsJaFHLgPTR22fB4czsRY%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASMZS2GASVCVSAV72NVCTWTS5LSWFANCNFSM4WYKXWEQ&data=04%7C01%7Cjoseph.rife%40vanderbilt.edu%7C55c616210b8e4347067008d8c93c35bd%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637480607719476484%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=VUuBbykgwR4SKJvOJGvmI1GAnEmSgOlqEgEa5E1ML0s%3D&reserved=0.
This has been fixed in data and here. I believe this is fixed but am leaving open to test
FYI, It looks like the data needs to be re-uploaded to the server? The data fix mentioned in this issue is fixed on GitHub but is still wrong on the server (both on production and the VU dev app).
@wlpotter Is the data on the server up to date now? If so, please close, if not I will reload it.
@wsalesky yes, the data is up to date, so this issue can be closed.
Hi folks in the chronology for dating testimonia, let's fix the one that currently reads "British Territorial Administration Period 1970-1920 CE" to "British Territorial Administration 1917-1920" thx