search

srophe / caesarea

Application repository for Caesarea-Maritima.org
GNU General Public License v3.0
0 stars 0 forks source link

Map browse for Caesarea Maritima Testimonia module #27

Closed wlpotter closed 4 years ago

wlpotter commented 4 years ago

Splitting off the discussion of map browse from the more general issue #6

davidamichelson commented 4 years ago

Please add filter to the map, similar to BQ, include all the facet options that are available in the All Browse

wsalesky commented 4 years ago

Added filters. @wlpotter @davidamichelson Please review and close if you approve.

wsalesky commented 4 years ago

@wsalesky Rerun the Place Data.

wsalesky commented 4 years ago

@davidamichelson I think the data is correct, this is the data given by Pleiades. If you look at their map, the point is in the ocean as well. We can hand code it if you would rather?

https://pleiades.stoa.org/places/991396/json https://pleiades.stoa.org/places/991396

wlpotter commented 4 years ago

@wsalesky sorry, we weren't clear on this. We replaced that Pleiades URI in the testimonia XML so that the records associated with Palestine point to this URI: https://pleiades.stoa.org/places/687995. (Cf. this issue and associated commit)

I think the testimonia data itself needs to be updated on the server?

wsalesky commented 4 years ago

Fixed!