search

srophe / caesarea

Application repository for Caesarea-Maritima.org
GNU General Public License v3.0
0 stars 0 forks source link

Update style of "Browse Source Text" link #381

Closed josephrife closed 1 year ago

josephrife commented 2 years ago

We dont need this here anymore, only a place to link over to an online source when that is useful

davidamichelson commented 2 years ago

Make an issue on the font size

davidamichelson commented 1 year ago
Screen Shot 2022-12-01 at 3 05 51 PM
davidamichelson commented 1 year ago

@wsalesky Please see the above picture of the "Browse source text" link. Can you remind us of the logic of the script that makes this appear? Is it looking for a TEI:ref in text/body/ab/ref?

We seem to have two different paths generating this link:

See https://github.com/srophe/caesarea-data/blob/master/data/testimonia/tei/130.xml#L293

and https://github.com/srophe/caesarea-data/blob/master/data/testimonia/tei/11.xml#L286

davidamichelson commented 1 year ago

Also, while you are at it can you change the styling on "Browse source text". Please set the font size to be smaller, the same as "Textual Note" in https://caesarea-maritima.org/testimonia/130

wsalesky commented 1 year ago

@wlpotter data issue.

wlpotter commented 1 year ago

Data issue now in https://github.com/srophe/caesarea-data/issues/164

wlpotter commented 1 year ago

Oh sorry, @wsalesky I forgot that the other part of this is to update the format of these "Browse Source Text" links.

From @davidamichelson 's comment above

Also, while you are at it can you change the styling on "Browse source text". Please set the font size to be smaller, the same as "Textual Note" in https://caesarea-maritima.org/testimonia/130

wsalesky commented 1 year ago

Fixed styles.