URI search

[dlschwartz]

@wsalesky What exactly does the URI search look at? George pointed out that we get results from just searching for a name "aba": http://wwwb.library.vanderbilt.edu/exist/apps/e-gedsh/search.html?q=&placeName=&persName=&bibl=&uri=aba.

Should that happen?

He also asked whether searching by a URI should return only one entry. That is of course not the case because all of the cross references in e-GEDSH use the same gedsh URI for that reference and a syriaca.org URI can appear in many contexts.

Do you have any thoughts on how we can clarify this search for less technically savvy users? @davidamichelson?

[wsalesky]

@dlschwartz Honestly I don't remember what it was supposed to search, if we can clarify I can adjust the code.

[wsalesky]

@dlschwartz @davidamichelson I have updated the regex on the URI search so that it is more restrictive, it will only return exact matches for tei:idno[@type='URI'], @ref, and @target so a search for http://gedsh.bethmardutho.org/Aba will return 8 results, one entry and 7 entries which references http://gedsh.bethmardutho.org/Aba in tei:ref/@target.

[dlschwartz]

The updated regex for URI search looks good to me. We would like to follow the model on the Gazetteer:

In GEDSH the implementation would have the label "URI:" The asterisk below should read "Enter GEDSH or Syriaca URI, ex. http://gedsh.bethmardutho.org/Aba, or http://syriaca.org/person/13"

@davidamichelson Please write and post to this issue a blurb to appear in a popup explaining what a URI is and how to use this search.

[wsalesky]

Added hint.

[dlschwartz]

I like this. @davidamichelson let us know if you want to add anything to the popup.

[davidamichelson]

Looks good so far! Can we change the pop up to this please:

"Searches the entire XML data and returns the entries that reference the specified URI(s)."

[wsalesky]

Done.

[davidamichelson]

My mistake, in both the pop up and the hint, please change "GESDH" to "e-GEDSH" also please change the pop up to: "Searches the entire XML data and returns the entries that reference the specified URI(s)." which is shorter.

[wsalesky]

@davidamichelson Updated.

[davidamichelson]

Great!

[dlschwartz]

@wsalesky I can't see the popup. I hover over it and I get the popup flashing like a strobe light. It's so fast I can't read it. I'm in Chrome on a PC.

[davidamichelson]

It works for me on firefox for mac

On Tue, Apr 24, 2018 at 3:50 PM, Daniel Schwartz notifications@github.com wrote:

@wsalesky https://github.com/wsalesky I can't see the popup. I hover over it and I get the popup flashing like a strobe light. It's so fast I can't read it. I'm in Chrome on a PC.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/srophe/e-gedsh/issues/205#issuecomment-384075449, or mute the thread https://github.com/notifications/unsubscribe-auth/AC8N_T61VBlristqwVrAMi3Eh9T8avnlks5tr5AGgaJpZM4Tdk1P .

[dlschwartz]

I hate to say it but I actually opened IE and it works fine there.

[wsalesky]

@dlschwartz Does this happen even with a hard refresh?

[dlschwartz]

@wsalesky A hard refresh didn't do the trick but it's working now. I've turned my computer on and off, maybe that explains it. Does this close the issue? I think so.

[wsalesky]

Yes!