srophe / srophe-eXist-app

DEPRECATED eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
10 stars 12 forks source link

Name variants in SPEAR #1017

Closed dlschwartz closed 7 years ago

dlschwartz commented 7 years ago

@wsalesky SPEAR aggregation pages are currently incorrectly grabbing some name variants. See here: http://wwwb.library.vanderbilt.edu/exist/apps/srophe/spear/aggregate.html?id=http://syriaca.org/person/2201. The third name variant is actually a name for an anonymous group that happens to include the URI for person/2201.

In such cases, the name variant applies only to the URI in the ref attribute on the persName element that is the immediate child of the person or personGrp element.

`

The nobles of Abgar of Edessa` Thanks Winona
dlschwartz commented 7 years ago

That code didn't render very well in the issue. See here: http://wwwb.library.vanderbilt.edu/exist/apps/srophe/spear/119-29/tei

wsalesky commented 7 years ago

So which names do you expect to see here?

dlschwartz commented 7 years ago

The third example, "The nobles of Abgar....", appearing here: http://wwwb.library.vanderbilt.edu/exist/apps/srophe/spear/aggregate.html?id=http://syriaca.org/person/2201 should not appear as a name variant for Abgar VIII.

Rather, this name variant should only appear as a name variant here: http://wwwb.library.vanderbilt.edu/exist/apps/srophe/spear/aggregate.html?id=http://syriaca.org/person/2233

I think the app is considering any name variant factoid to be a name variant of any URI appearing inside the persName element. Instead, it should consider the name variant factoid to be a name variant only for the immediate child of the person or personGrp element.

Does that help?