srophe / srophe-eXist-app

DEPRECATED eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
10 stars 12 forks source link

HTML rendering of Confessions in place/78 #1130

Open davidamichelson opened 5 years ago

davidamichelson commented 5 years ago

@wsalesky, this is not a bug to fix, so please don't change it just now even it if turns out to be a bug.

We are having trouble figuring out why the HTML for http://syriaca.org/place/78.html looks different from the XML (especially the dates).

Specifically, see this section in the HTML:

    Christians (attested as early as 201, as late as 201) 1
        Syriac (attested as early as 520, as late as 1624)
            West Syrian (attested as early as 520, as late as 1624)
                Melkite (attested as early as 522, as late as 540, as late as 540)
                Syrian Orthodox (attested as early as 520, as late as 1624) 1
        Latin (no attestations yet recorded) 1
    Jews (no attestations yet recorded) 11
    Muslims (no attestations yet recorded) 1

This does not seem to have the same data for dates as found here: https://github.com/srophe/srophe-app-data/blob/master/data/places/tei/78.xml#L234-L253

   <state type="confession" xml:id="confession78-2" ref="http://syriaca.org/documentation/confessions.xml#christians" from="0030" to="1924" source="#bib78-1" syriaca-computed-end="1924-01-01" syriaca-computed-start="0030-01-01">
                        <label>Christians</label>
                    </state>
                    <state type="confession" xml:id="confession78-1" ref="http://syriaca.org/documentation/confessions.xml#syrian-orthodox" from="0451" to="1924" source="#bib78-1" syriaca-computed-end="1924-01-01" syriaca-computed-start="0451-01-01">
                        <label>Syrian Orthodox</label>
                    </state>
                    <state type="confession" xml:id="confession78-3" ref="http://syriaca.org/documentation/confessions.xml#melkite" from="0451" to="0641" syriaca-computed-end="0641-01-01" syriaca-computed-start="0451-01-01">
                        <label>Melkite</label>
                    </state>
                    <state type="confession" xml:id="confession78-4" ref="http://syriaca.org/documentation/confessions.xml#muslims" from="0641" source="#bib78-1" syriaca-computed-start="0641-01-01">
                        <label>Muslims</label>
                    </state>
                    <state type="confession" xml:id="confession78-5" ref="http://syriaca.org/documentation/confessions.xml#latin" from="1098" to="1144" source="#bib78-1" syriaca-computed-end="1144-01-01" syriaca-computed-start="1098-01-01">
                        <label>Latin</label>
                    </state>
                    <state type="confession" xml:id="confession78-6" ref="http://syriaca.org/documentation/confessions.xml#jews" from="0050" to="0424" source="#bib78-11" syriaca-computed-end="0424-01-01" syriaca-computed-start="0050-01-01">
                        <label>Jews</label>
                        <precision match="@from" notAfter="0100" syriaca-computed-end="0100-01-01"/>
                        <precision match="@to" notBefore="0412" syriaca-computed-start="0412-01-01"/>
</state>

Lastly, the reason we found this issue is that we are wondering how the HTML handles having two TEI:precision elements as children of TEI:state. But perhaps the answer is that it is not?

Thanks!

wsalesky commented 5 years ago

@davidamichelson The confessions HTML output is pretty knarly. The XSLT looks for a t:event[@type='attestation'] which references the confession via a t:link[@target="#CONFESSION-ID"], and then uses the date from the tei:event, not the dates in the t:state[@type="confession"]

So the data behind the first confession in place 78:

Christians (attested as early as 201, as late as 201)

Is pulled from this line: https://github.com/srophe/srophe-app-data/blob/master/data/places/tei/78.xml#L208

I hope that makes sense.