srophe / srophe-eXist-app

DEPRECATED eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
10 stars 12 forks source link

Birth date and death date not showing in person aggregation page #1174

Closed dlschwartz closed 4 years ago

dlschwartz commented 4 years ago

@wsalesky I don't see examples of birth place and death place appearing in the "Person factoids about ...." section on a person aggregation page.

Death HTML: http://wwwb.library.vanderbilt.edu/exist/apps/srophe/spear/aggregate.html?id=http://syriaca.org/person/13 TEI: https://github.com/srophe/srophe-app-data/blob/dev/data/spear/tei/8559.xml#L3796

Birth HTML: http://wwwb.library.vanderbilt.edu/exist/apps/srophe/spear/aggregate.html?id=http://syriaca.org/person/608 TEI: https://github.com/srophe/srophe-app-data/blob/dev/data/spear/tei/8559.xml#L1916

wsalesky commented 4 years ago

@dlschwartz How do we want dates in a tei:choice element to display? See: http://wwwb.library.vanderbilt.edu/exist/apps/srophe/spear/aggregate.html?id=http://syriaca.org/person/13

dlschwartz commented 4 years ago

@wsalesky I think on the aggregation page we should just have "Ephrem died on 9 June 373". And actually, the aim of the factoid page is to present a human readable version of the data so there as well I believe we would want the same. For serialization into RDF we'd get into the tei:choice element.

wsalesky commented 4 years ago

Fixed.