search

srophe / srophe-eXist-app

DEPRECATED eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
10 stars 11 forks source link

Factoid types, esp. birth and death #1195

Closed dlschwartz closed 4 years ago

dlschwartz commented 4 years ago

@wsalesky birth/death place factoids each getting registered as both birth/death date and birth/death place: http://wwwb.library.vanderbilt.edu/exist/apps/srophe/spear/aggregate.html?id=http://syriaca.org/person/1546 http://wwwb.library.vanderbilt.edu/exist/apps/srophe/spear/aggregate.html?id=http://syriaca.org/person/2032

I'm wondering if all factoids should have a subtype attribute: name, birthPlace, birthDate, deathPlace, deathDate, education, languageKnown, citizenship, occupation, residence, socialRank, sanctity, gender, physicalTrait, ethnicLabel, event, relation. I can easily add this using RegEx and it would help address the problem.

wsalesky commented 4 years ago

@dlschwartz I can catch this in the XSLT. Taking a look today. On second thought a subtype would be helpful! Then I don't have to hard code the types into the code. Just add a sample facoid to this thread so I can use it to write the code.

wsalesky commented 4 years ago

@dlschwartz I think this has been fixed.

dlschwartz commented 4 years ago

@wsalesky Thank you. I've added the subtype attribute on div in case you hadn't seen that. I did it late on Friday and forgot to send you a message about it. Thanks.