search

srophe / srophe-eXist-app

DEPRECATED eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
10 stars 11 forks source link

Change to Schema Allow Location to have @resp or @source #1201

Open davidamichelson opened 4 years ago

davidamichelson commented 4 years ago

Instead of requiring @source could we require @resp or @source in TEI:location

davidamichelson commented 4 years ago

See place 4160 in BQG

davidamichelson commented 4 years ago 
          <location type="nested" resp="http://bqgazetteer.bethmardutho.org">
            <region ref="http://bqgazetteer.bethmardutho.org/place/37">Beth Qaṭraye</region>
          </location>
dlschwartz commented 4 years ago

@davidamichelson look at line 1859 here and also at line 1862. I think this is what you want but I want to confirm. I will add the same schematron rules (mutatis mutandis) to if you want the same rules to apply there. If you want something different, just let me know.

davidamichelson commented 4 years ago

Quick question, if I am correct it looks like your schema rule is putting this on TEI:placeName, but we would prefer to require it on TEI:location. Am I misreading?

dlschwartz commented 4 years ago

It currently exists in placeName. I'll also put it on location if that's what you want. Just make sure you want these rules: either source or resp is required, both source and resp cannot appear together.

davidamichelson commented 4 years ago

Okay, got it now.

Here is what we would like please.

  1. Require either @source or @resp on TEI:location

  2. But make a new change to placeName now that we are aware of a possible issue. @source or @resp should only be required on TEI:placeName when placeName is the child of TEI:place. When placeName occurs in a TEI:desc for instance we don't want to require @source or @resp (see http://syriaca.org/place/600/tei as an example)

Thanks!

Adding link to issue: https://github.com/srophe/bethqatraye-data/issues/25

dlschwartz commented 4 years ago

@davidamichelson great. However, see https://github.com/srophe/draft-data/blob/master/data/schemaPlaceDraftData/syriacaPlacesTEI.odd#L1857. The context should already be set to require source or resp on placeName only when it's the child of place. Are you getting an error message when you use a placeName in a desc element?

dlschwartz commented 4 years ago

@davidamichelson I've implemented this change and pushed it: https://github.com/srophe/draft-data/commit/925e29d5c3b729254219e3f261aceff487740375.

Test the placeName and location rules in practice. Close this issue if all looks good or let me know if you need changes.