search

srophe / srophe-eXist-app

DEPRECATED eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
10 stars 12 forks source link

Relationships between events #1206

Closed dlschwartz closed 4 years ago

dlschwartz commented 4 years ago

@wsalesky I found an error in the display of relationships between events. I thought there was an old issue on this I could re-open but I can't seem to find it. The "Relation:" option is correct and the "Relationship:" option is incorrect. What's appears there should be generated out of a element inside . What's appearing in the "Relationship:" option is being generated by the app.

Also, the link doesn't work. It takes the user to an aggregation page with no results rather than to the other event factoid page. Thanks.

wsalesky commented 4 years ago

@dlschwartz example record to check?

dlschwartz commented 4 years ago

@wsalesky I thought I put a link in there. Sorry. http://wwwb.library.vanderbilt.edu/exist/apps/srophe/spear/factoid.html?id=http://syriaca.org/spear/8559-554

wsalesky commented 4 years ago

@dlschwartz This is fixed. Should I update the data on the dev server to include the new relationships with descriptions? Otherwise this code breaks the relationship factoid display (until the new data is up).

dlschwartz commented 4 years ago

@wsalesky yes, let's go ahead and update that data. Thank you.

wsalesky commented 4 years ago

Updated data: https://github.com/srophe/srophe-app-data/pull/785

dlschwartz commented 4 years ago

@wsalesky great, thank you.