search

srophe / srophe-eXist-app

DEPRECATED eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
10 stars 11 forks source link

Relation, change @ref to @name #1208

Closed dlschwartz closed 4 years ago

dlschwartz commented 4 years ago

@wsalesky in writing up an article on SPEAR I've realized that I have a datatype error I need to fix. I've incorrectly used @ref on the relation element. I will need to change that to @name. The values will stay the same. This will be relevant to all relation factoids and to relations in event factoids. Rather than break everything, I've made that change in a branch of dev (ref-2-name). Feel free to merge that change into dev whenever it suits you. Thanks Winona.

wsalesky commented 4 years ago

@dlschwartz Okay. I will try to get to it tomorrow.

wsalesky commented 4 years ago

@dlschwartz I tested this and it does not seem to break anything, so I have merged it into dev. Let me know if you run into any problems.

dlschwartz commented 4 years ago

@wsalesky this looks great, thanks. And I love how fast things are now that we have desc elements in relation factoids!!!

wsalesky commented 4 years ago

@dlschwartz Great to hear that the speed is better!