search

srophe / srophe-eXist-app

DEPRECATED eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
10 stars 12 forks source link

Issue #1221 #1223

Closed davidamichelson closed 4 years ago

davidamichelson commented 4 years ago

Added dynamic linking of icons for e-GEDSH URLS

@wsalesky Look, I updated the app! I did not know if I should use the e-gedsh.png or the e-gedsh favicon, hopefully the png is the correct one. Would you please check my work?

Thanks!

Fixes Issue #1221

dlschwartz commented 4 years ago

@davidamichelson I'm not sure how to review this when there are two reviewers (I'm guessing Winona should actually merge the pull request). It looks good to me though.

davidamichelson commented 4 years ago

Yep, this is for Winona, just wanted you to know about.

On Thu, Jun 18, 2020 at 11:13 AM Daniel Schwartz notifications@github.com wrote:

@davidamichelson https://github.com/davidamichelson I'm not sure how to review this when there are two reviewers (I'm guessing Winona should actually merge the pull request). It looks good to me though.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/srophe/srophe-eXist-app/pull/1223#issuecomment-646132398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXQ37JEVVIC66XAGOD6KN3RXI4IZANCNFSM4OBAZVZA .