search

srophe / srophe-eXist-app

DEPRECATED eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
10 stars 12 forks source link

Controller does not handle record ids that contain characters #975

Closed wsalesky closed 7 years ago

wsalesky commented 7 years ago

This came up in testing the keywords. Will we have id's that are not numeric? @davidamichelson @dlschwartz

nathangibson commented 7 years ago

My understanding is that the subjects module will use the subject name as the URI. So yes.

wsalesky commented 7 years ago

I mean thanks! This will take a little finagling to get it to work correctly. I will see what I can do.

dlschwartz commented 7 years ago

Let's discuss tomorrow. We could (and really probably should) give subjects numeric URIs just like our other entities. We prefer human-readable in this instance. If we had a good reason to abandon that though, we could consider it.

wsalesky commented 7 years ago

It is fine, just takes slightly more mental gymnastics on my part and the part of our controller.xql.