srophe / syriac-corpus-app

This is the development repository for The Oxford-BYU Syriac Corpus project. Application development.
Other
3 stars 2 forks source link

Font size and whitespace for line numbers, page breaks etc. #128

Closed davidamichelson closed 4 years ago

davidamichelson commented 6 years ago

@wsalesky @jedwardwalters There are some cut and paste and some formatting issues which are related to the numbering in the corpus. Let's discuss in person.

davidamichelson commented 6 years ago

Insert numbers to the right in the RTF file and include a whitespace both in the RTF and the HTML

wsalesky commented 6 years ago

@davidamichelson @jedwardwalters Added. Please take a look. The .txt view is now available on dev.

davidamichelson commented 6 years ago

@wsalesky whitespace in the HTML works fine and the numbers and text cut and paste fine so that is done.

On the .txt download. There are a couple of issues:

  1. The button displays in my browser rather that automatic download. I can download by right click, but is there a way to force download?
  2. There are no numbers in the .txt version. I think we do want them in there with the same whitespace as the HTML.
  3. The .txt has too much whitespace in it. The citation is fine, but for the text itself the layout of the lines (how they wrap) seems to be hardcoded with whitespaces. Can we instead just keep line breaks from the TEI so the text wraps based on the new document when cut and pasted? Do we need to format the page as RTF to do this?
  4. The citation at the top is correct, but has no formatting because this is a .txt file. If we move to RTF could we keep the italics on the title?
wsalesky commented 6 years ago

@davidamichelson @jedwardwalters

  1. Done. I have forced the text to download automatically.
  2. I added the numbers in.
  3. Removed excess whitespace
  4. To add formatting and create a true RTF version of the citation will take a few hours (3ish). Do you want me to invest the time into that?
davidamichelson commented 6 years ago

Thanks! There are still some issues including in issue # 121 so let's discuss on Monday. This may be good for now! Please keep these open so we can discuss.

On Wed, May 9, 2018 at 8:14 AM, Winona Salesky notifications@github.com wrote:

@davidamichelson https://github.com/davidamichelson @jedwardwalters https://github.com/jedwardwalters

  1. Done. I have forced the text to download automatically.
  2. I added the numbers in.
  3. Removed excess whitespace
  4. To add formatting and create a true RTF version of the citation will take a few hours (5ish). Do you want me to the time invest into that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/srophe/syriac-corpus-app/issues/128#issuecomment-387734282, or mute the thread https://github.com/notifications/unsubscribe-auth/AC8N_cSQN4NXdwT94uVFZq67HU5Bm9onks5twuvJgaJpZM4TuaLJ .

wsalesky commented 6 years ago

@davidamichelson @jedwardwalters Please review spacing and numbering on the dev server version of the text download. If this looks okay I will move it to Production.

davidamichelson commented 6 years ago

@wsalesky DEV server appears to be down http://wwwb.library.vanderbilt.edu/exist/apps/syriac-corpus/100

On Wed, May 16, 2018 at 8:44 AM, Winona Salesky notifications@github.com wrote:

@davidamichelson https://github.com/davidamichelson @jedwardwalters https://github.com/jedwardwalters Please review spacing and numbering on the dev server version of the text download. If this looks okay I will move it to Production.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/srophe/syriac-corpus-app/issues/128#issuecomment-389523576, or mute the thread https://github.com/notifications/unsubscribe-auth/AC8N_RhSkN2lR7Pl9ykNzP8ntstc8X2Fks5tzC1IgaJpZM4TuaLJ .

wsalesky commented 6 years ago

Fixed

davidamichelson commented 6 years ago

This looks great and did what we wanted...but sorry to re-open. There is now an extra period in the citation (after the date):

"London: British and Foreign Bible Society, 1905).. Digital Syriac Corpus."

This extra period is not appearing on the HTML page so not sure why it is appearing here.

Dave

davidamichelson commented 6 years ago

Note, this period only appears in the copy button contents or the download txt button file

wsalesky commented 6 years ago

Fixed. Close if the text output looks okay.

wsalesky commented 4 years ago

stale issue.