search

srophe / syriac-corpus-app

This is the development repository for The Oxford-BYU Syriac Corpus project. Application development.
Other
3 stars 2 forks source link

Page break toggle makes page unresponsive. #248

Closed wsalesky closed 2 years ago

davidamichelson commented 2 years ago

Okay, after discussing with @dlschwartz we have decided to just always show page breaks. Perhaps this can be fixed in the future. @jedwardwalters Does this sound okay?

jedwardwalters commented 2 years ago

That’s fine with me!

Jamey

On Apr 14, 2022, at 11:28 AM, David Michelson @.***> wrote:

Okay, after discussing with @dlschwartz https://github.com/dlschwartz we have decided to just always show page breaks. Perhaps this can be fixed in the future. @jedwardwalters https://github.com/jedwardwalters Does this sound okay?

— Reply to this email directly, view it on GitHub https://github.com/srophe/syriac-corpus-app/issues/248#issuecomment-1099302281, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYCJ6F2CTVMSLQCHMDISHTVFA2RDANCNFSM5TBHNPZQ. You are receiving this because you were mentioned.

wsalesky commented 2 years ago

@jedwardwalters I think I have a fix for this, can you run a few tests? I streamlined the javascript.

wsalesky commented 2 years ago

I think this is fixed. Reopen if not.