search

srophe / syriaca-data

Repository for Syriaca.org TEI data, used by srophe-eXist-app.
4 stars 16 forks source link

HTML # anchors in Wiki do not work when transformed to the Server #776

Closed davidamichelson closed 4 years ago

davidamichelson commented 5 years ago

The anchors work on the actual wiki page:

https://github.com/srophe/srophe-app-data/wiki#relationships-using-relation

But when they are on the server version of the wiki they no longer work:

http://syriaca.org/documentation/wiki.html?wiki-page=/TEI-Encoding-Manual-for-The-Syriac-Gazetteer&wiki-uri=https://github.com/srophe/srophe-app-data/wiki#relationships-using-relation

Probably because the URL contains a URL within it?

Not an urgent issue but worth paying you to fix please :)

davidamichelson commented 5 years ago

Assigning Will to watch

wsalesky commented 4 years ago

@wsalesky Note to self the wiki does not use standard anchors. See: <a id="user-content-relationships-using-relation" class="anchor" href="#relationships-using-relation" aria-hidden="true">

Can probably be solved with a little JavaScript.

davidamichelson commented 4 years ago

@wsalesky could you do this issue when you get a chance and apply to the srophe app everywhere.

wsalesky commented 4 years ago

Fixed.

wsalesky commented 4 years ago

@davidamichelson Webhooks on Production are having issues. I will try to debug, but am putting most of my time into getting the new versions up and running. The new versions will all include this fix.

davidamichelson commented 4 years ago

That makes sense, don't worry about production right now. Those bugs can wait.

On Wed, Jun 10, 2020 at 11:27 AM Winona Salesky notifications@github.com wrote:

@davidamichelson https://github.com/davidamichelson Webhooks on Production are having issues. I will try to debug, but am putting most of my time into getting the new versions up and running. The new versions will all include this fix.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/srophe/srophe-app-data/issues/776#issuecomment-642120289, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXQ37MAPO2O5OZNUXS4IE3RV6X65ANCNFSM4I35NGHA .