srophe / syriaca-data

Repository for Syriaca.org TEI data, used by srophe-eXist-app.
4 stars 16 forks source link

@ref on state type="confession" #842

Open dlschwartz opened 4 years ago

dlschwartz commented 4 years ago

@davidamichelson @wlpotter am I right that @ref is required on <state type="confession">? The schema currently does not require this. I can add that requirement and validate the value of @ref against https://github.com/srophe/srophe-eXist-app/blob/master/documentation/confessions.xml.

Do you have any objections?

wlpotter commented 4 years ago

@dlschwartz it looks like, at least in places, every <state type="confession"> has a @ref attribute.

A spot-check shows they are currently pointing at "http://syriaca.org/documentation/confessions.xml but I don't know if that is the case for all of them. I can't think of a case where we would want to have it point elsewhere, so this seems like a good addition to the schema.

dlschwartz commented 4 years ago

@wlpotter the commit above does the following:

The last two work but are a little clumsy because I'm having trouble figuring out how to move between regex and schematron functions to match the text node in <label> against the relevant portion of the @ref [which is all lowercase and has '-'s]. Anyway, it should work and I'll likely revisit this again. Please let me know if you encounter any problems.

wlpotter commented 1 year ago

connected to #1042