search

srophe / syriaca-data

Repository for Syriaca.org TEI data, used by srophe-eXist-app.
4 stars 16 forks source link

Some "identity" statements not showing in search results #911

Open dlschwartz opened 3 years ago

dlschwartz commented 3 years ago

@wlpotter @wsalesky Please check out this search result. Notice that numbers 6 and 7 don't display the "identity" statement that displays in the others. This is actually the norm for more recently created persons records. I'm trying to figure out why because this information is really helpful.

Both records have a <note xml:lang="en" type="abstract">. See person/467 and person/2640. The only difference I see is that person/2640 has a @source attribute and no @xml:id while person/467 has the opposite.

It looks like I'm missing what the app looks for in the data to display that note in search results. Winona, can you tell us what's missing? Will, can we make sure to include whatever is missing in the CSV to TEI transforms?

Thanks.

wlpotter commented 3 years ago

@wsalesky It looks to me like the app is looking for the @xml:id with a value of the form abstract-en-\d+ (where \d+ is the numerical portion of the URI).

@dlschwartz the CSV to TEI transforms will always put an @xml:id on abstracts

wlpotter commented 2 years ago

I believe fixing #925 should also fix this issue but will leave open until batch changes are done so we can check and make sure these identity statements are showing up in the search results