Revisit suggestion logic

srosro commented 2 months ago

When do we kickoff a "set" of suggestions
- User feedback: "the assistant a bit to speedy as soon a a key is pressed, he start to send request to API, so the first responses are not so usefull. I get 3 to 5 responses for a single line typed."
- We should probably kickoff a new set 100% of the time the user executes an sm command ...
- If possible, we probably should not kickoff a new set when the user getting a ton of input (e.g., this user feedback: "I start my rails server and every log are observed by shellmate, It can be usefull to ignore some tabs on the terminal.")
What is the criteria for generating additional suggestions?
Can allow the user to request additional suggestions (e.g. if shellmate gets the "intent" right but the suggestion is wrong)?

srosro commented 2 months ago

Also, see this user feedback:

srosro commented 2 months ago

Next step is for either @plonkus or @delattre1 to review user feedback above and propose changes to the current suggestion logic.

plonkus commented 2 months ago

Will chat with @maryldyer about possible solutions before estimating fix

delattre1 commented 1 month ago

Increased the debouncer threshold from 1s -> 1.5s
Logic to store new terminal state as pending (if previous state is still being processed)
Logic to avoid thread errors

delattre1 commented 1 month ago

Also the user already has the ability to pause the suggestions for any specific window

srosro / deepspring-shellmate