Refactor Warnings Display: Consider Scrollable or Fixed Banner Approach

delattre1 commented 2 weeks ago

These warnings are currently not displayed in the same area as the suggestions and are not scrollable.

They remain fixed and only disappear when the issue is resolved.

Proposal

Option 1: Refactor these warnings to appear like the other fixed banners (e.g., 'Chat with Makers' or 'CLI is not installed').
Option 2: Make the warnings scrollable, similar to the pro-tips.
Option 3: Explore another approach to improve the user experience.

https://github.com/user-attachments/assets/1456808e-33c0-4eb3-9460-3734c6614b41

maryldyer commented 1 week ago

I think we should update the Network Error to be a fixed banner on the bottom (like the CLI error) but leave the other 2 as is. I'm ok with them not looking like the fixed alert banners but they are technically fixed to the bottom and persistent until the issue is resolved (which follows the fixed banner pattern)

delattre1 commented 1 week ago

Refactored the network error to be just like the CLI error

srosro / deepspring-shellmate

Refactor Warnings Display: Consider Scrollable or Fixed Banner Approach #146

Proposal