srossross / rpmfile

Read rmp archive files
MIT License
29 stars 37 forks source link

test_extract fails on isolated VM #35

Open jayvdb opened 3 years ago

jayvdb commented 3 years ago

When I run test_extract on a rpmbuild isolated VM, i.e. no network, the test fails.

It would be good if these tests used test data that is included in the PyPI sdist, or even test data which can be generated on the VM before the tests.

johnandersen777 commented 3 years ago

What kind of tools are available on this VM? I lean toward generating them and and rpmbuild VM sounds like a good place to build test rpms. Could you provide an example of how to build an rpm or a pointer to some documentation using tools / a tool within the VM? If so then I can take this the rest of the way and generate some RPMs as test files.

jayvdb commented 3 years ago

Anything that is already packaged for Fedora or openSUSE. Or I can create new packages for new tools you want to use, no problems.

Easiest way is to add a .spec as test data, and use rpmbuild.

johnandersen777 commented 3 years ago

@jayvdb Sorry I've been really strapped for time, do you think you could script the creation of those packages? That's what I was thinking of doing is building them within the setUpClass method of the extraction tests.