search

srounet / Pymem

A python library for windows, providing the needed functions to start working on your own with memory editing.
MIT License
303 stars 45 forks source link

fix is_64_bit (closes #113) #114

Closed StarrFox closed 7 months ago

StarrFox commented 7 months ago

this pull request fixes is_64_bit to hopefully return True if the process is 64_bit

I changed the old function to is_wow64 and changed the pointer_resolve method to use the new is_64_bit function which I also exposed as a property of Pymem

StarrFox commented 7 months ago

it seems the tests are failing because they're still testing for 3.6

functools.cached_property was added in 3.8 source which is the current oldest supported version source

can just switch it to a normal property if support for the eol versions is still wanted

srounet commented 7 months ago

Any idea if tests could be fixed ?

StarrFox commented 7 months ago

Any idea if tests could be fixed ?

I'm not sure if fixing them is desired since they fail from using an eol python version

srounet commented 7 months ago

Yes you are right about that, tests should be updated to supported python versions.

Let's ignore it for now, OK for merge

Le jeu. 9 nov. 2023, 17:27, StarrFox @.***> a écrit :

Any idea if tests could be fixed ?

I'm not sure if fixing them is desired since they fail from using an eol python version

— Reply to this email directly, view it on GitHub https://github.com/srounet/Pymem/pull/114#issuecomment-1804154930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABPQKTAX5STSQW7LKHIZWTYDUAANAVCNFSM6AAAAAA7AHGPRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGE2TIOJTGA . You are receiving this because you commented.Message ID: @.***>

srounet commented 7 months ago

Sorry for the delay

Le jeu. 9 nov. 2023, 17:30, Fabien R @.***> a écrit :

Yes you are right about that, tests should be updated to supported python versions.

Let's ignore it for now, OK for merge

Le jeu. 9 nov. 2023, 17:27, StarrFox @.***> a écrit :

Any idea if tests could be fixed ?

I'm not sure if fixing them is desired since they fail from using an eol python version

— Reply to this email directly, view it on GitHub https://github.com/srounet/Pymem/pull/114#issuecomment-1804154930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABPQKTAX5STSQW7LKHIZWTYDUAANAVCNFSM6AAAAAA7AHGPRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGE2TIOJTGA . You are receiving this because you commented.Message ID: @.***>

StarrFox commented 7 months ago

I can also do a pr to update supported versions