Do not throw a exception if Message does not support metadata

sroze / messenger-enqueue-transport

Uses Enqueue with Symfony's Messenger component.

MIT License

191 stars 55 forks source link

Do not throw a exception if Message does not support metadata #63

Open volkyeth opened 5 years ago

volkyeth commented 5 years ago

https://github.com/sroze/messenger-adapter/blob/89516be3de37961217c8e665e535a28f521df2c6/QueueInteropTransport.php#L217-L223

When adding transport-specific metadata through a TransportConfiguration it's not possible to use another transport type in the same bus, as it would have a different Message without the required setter.

I guess it would be ok to skip silently when the setter does not exist

malarzm commented 5 years ago

I'm :-1: as the exception saved me from thinking https://github.com/sroze/messenger-enqueue-transport/issues/66 would work

weaverryan commented 5 years ago

@malarzm can 66 be closed then? If not... I wasn't clear what the issue was.

malarzm commented 5 years ago

@weaverryan I think not as according to README #66 should work: https://github.com/sroze/messenger-enqueue-transport#setting-custom-configuration-on-your-message (amqp is mentioned there)