search

sroze / messenger-enqueue-transport

Uses Enqueue with Symfony's Messenger component.
MIT License
191 stars 55 forks source link

SQS + Symfony 4.3 deletion fail #71

Closed zeliard91 closed 5 years ago

zeliard91 commented 5 years ago

Hi,

The deletion of Amazon SQS messages is not working anymore with the new QueueInteropTransport inherited from Symfony 4.3.

Interop\Queue\Message\SqsMessage need to have the attribute receiptHandle defined in order to be deleted.

This worked before 4.3 because the same object was received and sent by the transport but now, as the messages are reconstructed with QueueInteropTransport::encodeMessage they loose this attribute.

Do you have any idea how this could be fixed ?

Thanks.

hoangnd25 commented 5 years ago

Hi,

I'm having similar issue with GpsMessage where nativeMessage is missing due to the message being reconstructed via QueueInteropTransport::encodeMessage

I think this is also breaking KafkaMessage #74

Is there any chance we could just skip the encoder for now?

mikeymclellan commented 5 years ago

In the meantime, I've downgraded to "enqueue/messenger-adapter": "^0.2.2"

tristanbes commented 5 years ago

What's the status of this report ? what's the recommendation if we're using SF4.3+ ?

Matth-- commented 5 years ago

@tristanbes the 0.3.1 release has the fix for ack/rejecting messages. I think this issue can be closed

https://github.com/sroze/messenger-enqueue-transport/releases/tag/0.3.1

tristanbes commented 5 years ago

Thanks :)

Matth-- commented 5 years ago

I can confirm the 0.3.1 and 0.3.2 release work with ack and nack.

@zeliard91 this issue can be closed

zeliard91 commented 5 years ago

OK thanks you, I close the issue