sroze / messenger-enqueue-transport

Uses Enqueue with Symfony's Messenger component.
MIT License
191 stars 55 forks source link

Default receive timeout not compatible with SQS #72

Open AlexStansfield opened 5 years ago

AlexStansfield commented 5 years ago

Just to let you know that the default receive timeout of 30 seconds introduced in version 0.2.0:

https://github.com/sroze/messenger-enqueue-transport/blob/8d08ee991d82f7ce41e20499fbcf988361756f3f/QueueInteropTransport.php#L69

Is incompatible with SQS (max 20 seconds):

https://github.com/php-enqueue/sqs/blob/b203de327b4f5045717b9420de071a19c0f78afc/SqsConsumer.php#L88

Not really a big deal but wasn't sure if 30 seconds was picked for a specific or arbitrary reason.

We're fixing our setup by setting the receive timeout, which is probably the best solution anyway, but thought you might consider updating the 30 seconds to 20 just to avoid confusion.

Spawnrad commented 4 years ago

Have the same issue. Watching where the 30s come from. Thanks a lot.

Is it possible to change the default value to 20s please?